Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rnv evaluation #23162

Merged
merged 1 commit into from
Feb 25, 2017
Merged

fix rnv evaluation #23162

merged 1 commit into from
Feb 25, 2017

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Feb 25, 2017 •
edited

This was breaking evaluation.

@mention-bot
Copy link

@edef1c, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@edef1c edef1c changed the title This was breaking evaluation. fix rnv evaluation Feb 25, 2017
@edef1c
Copy link
Member Author

edef1c commented Feb 25, 2017

Caused by #23132, which was apparently merged without anyone checking evaluation.

@ljli
Copy link
Contributor

ljli commented Feb 25, 2017

This was my bad, I pushed a change to the branch which wasn't as cosmetic as I hoped it was and apparently didn't recheck. Sorry.

@joachifm joachifm merged commit 447ba91 into NixOS:master Feb 25, 2017
@joachifm
Copy link
Contributor

Thanks

@edef1c edef1c deleted the fix-rnv branch February 25, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edef1c @mention-bot @ljli @joachifm