Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Use site-helper to login on page visit #2220

Closed
ianb opened this issue Feb 24, 2017 · 1 comment
Closed

Use site-helper to login on page visit #2220

ianb opened this issue Feb 24, 2017 · 1 comment
Assignees
@ianb
Milestone
Sprint 54.3

Comments

@ianb
Copy link
Contributor

ianb commented Feb 24, 2017

#2167 is fixed in 6adbfea we won't be setting the session cookie on startup.

As a result you could use Page Shot to create a shot (and create an account), then restart Firefox and lose your login cookie, and then return to a shot or /shots, and you wouldn't be logged in.

We can detect this in site-helper.js but then we have to deal with it. I'm not sure what's the best way to do that. We could trigger a login, but then the page will have been rendered as though you weren't logged in. I suppose we could change the model in-place and rerender without too much trouble.
@ianb
Copy link
Contributor Author

ianb commented Feb 24, 2017

Note that you might not be even registered at that moment, in which case we should probably not log you in.

@ianb ianb mentioned this issue Feb 24, 2017
Closed
@ckprice ckprice added this to the Page Shot in 54 milestone Mar 1, 2017
@ianb ianb modified the milestones: Page Shot in 54, Sprint 54.2 Mar 9, 2017
@ianb ianb self-assigned this Mar 14, 2017
@ghost ghost modified the milestones: Sprint 54.2, Sprint 54.3 Mar 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
Sprint 54.3
Development

No branches or pull requests
2 participants
@ianb @ckprice