Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write nikola serve -d PID to file #2683

Merged
merged 1 commit into from Feb 26, 2017
Merged

Write nikola serve -d PID to file #2683

merged 1 commit into from Feb 26, 2017

Conversation

Kwpolska
Copy link
Member

Write the PID of the detached nikola serve process to a file. If the user forgets to write the PID down, or it scrolls away, going to htop is not necessary anymore.

As an added bonus, clean up if nikola serve is killed with SIGTERM.

@Kwpolska
Write nikola serve -d PID to file
8c43807 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
felixfontein
felixfontein approved these changes Feb 26, 2017
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I haven't tested this, but the code looks good.)

@Kwpolska Kwpolska merged commit c2fa5f7 into master Feb 26, 2017
@Kwpolska Kwpolska deleted the serve-pidfile branch February 26, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kwpolska @felixfontein