Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retroarch: libretro-mednafen-* -> libretro-beetle-* #23176

Merged
merged 1 commit into from
Feb 26, 2017

Conversation

hrdinka
Copy link
Contributor

@hrdinka hrdinka commented Feb 25, 2017

Renames all mednafen-* libretro ports to beetle-* due #23163.

Alle derivation products (executables & libraries) are still called mednafen-* (that's what libretro's makefiles produce). That's why the core variables are still named that way (and why it has been named like that initially). However all package attributes & names are changed. I've added exceptions for old nix config files, I guess that this should be sufficient to inform our users about the change. Only users who aren't using the the config interface and have installed the packages explicitly won't get updates when installed by name or an error when installed by attribute. I don't believe that an alias is necessary.

@mednafen thanks for the clarification. Libretro's repos do use both names interchangeably without explaining why the alternate exists.

Closes #23163.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Rename all mednafen-* libretro ports to beetle-* due NixOS#23163.

Closes NixOS#23163.

Signed-off-by: Christoph Hrdinka <c.github@hrdinka.at>
@mention-bot
Copy link

@hrdinka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @dezgeg and @MP2E to be potential reviewers.

@hrdinka hrdinka added this to the 17.03 milestone Feb 25, 2017
@edwtjo edwtjo merged commit a78b801 into NixOS:master Feb 26, 2017
@edwtjo
Copy link
Member

edwtjo commented Feb 26, 2017

Looks good, thanks!

@hrdinka hrdinka deleted the retroarch/mednafen2beetle branch February 26, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants