Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iana-etc: fixed source URL and homepage #23167

Merged
merged 1 commit into from
Feb 25, 2017
Merged

iana-etc: fixed source URL and homepage #23167

merged 1 commit into from
Feb 25, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Feb 25, 2017

Motivation for this change

It seems the homepage has moved years ago. The source URL was wrong.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Fixed iana-etc source URL and homepage
42353c5 
The homepage has moved years ago.
@mention-bot
Copy link

@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra to be a potential reviewer.

@fpletz
Copy link
Member

fpletz commented Feb 25, 2017

Thanks!

@fpletz fpletz merged commit 56a4640 into NixOS:master Feb 25, 2017
@fpletz
Copy link
Member

fpletz commented Feb 25, 2017

Squashed to fix commit message to meet our contributing guidelines.

@c0bw3b c0bw3b deleted the pkg/iana-etc branch February 25, 2017 13:09
@c0bw3b c0bw3b mentioned this pull request Mar 7, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @mention-bot @fpletz