nghttp2: 1.19.0 -> 1.20.0 #23944
nghttp2: 1.19.0 -> 1.20.0 #23944
Conversation
|
@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @domenkozar to be potential reviewers. |
| ++ optional enableAsioLib "--enable-asio-lib --with-boost-libdir=${boost}/lib"; | ||
|
|
||
| preInstall = '' | ||
| substituteInPlace script/fetch-ocsp-response --replace '#!/usr/bin/env' '#!/run/current-system/sw/bin/env' |
There was a problem hiding this comment.
what is the difference between the two?
There was a problem hiding this comment.
The difference is that the latter won’t work on non-nixos, right? I thought, we were not doing this kind of things.
There was a problem hiding this comment.
Yeah, please don't use global paths like that. There are very few guarantees about what will be in /sw/bin/ anyway, and even NixOS has /usr/bin/env. If you must patch it to something else, make it use an explicit full path from coreutils.
There was a problem hiding this comment.
Yes my bad, this is not right outside NixOS. I will correct.
| }; | ||
|
|
||
| outputs = [ "out" "dev" "lib" ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ openssl libev zlib libcares ] | ||
| buildInputs = [ openssl libev zlib c-ares systemd.dev ] |
There was a problem hiding this comment.
Adding systemd, causes an infinite recursion.
There was a problem hiding this comment.
From my understanding systemd is only used for the server component, maybe this could be a different derivation.
There was a problem hiding this comment.
It is probably a good idea to avoid systemd as much as possible, as it is Linux-only.
There was a problem hiding this comment.
Or make it conditional on stdenv.isLinux
There was a problem hiding this comment.
SystemD is useful for nghttpx binary to support being instrumented with a unit service, which would open the door to a future service module.
But I agree it should be conditional on stdenv.isLinux. I will correct that.
@Mic92 : having two derivation would not be much more practical and it was already reversed in the past by edolstra in favor of a single multi-output derivation.
There was a problem hiding this comment.
@c0bw3b conditional inclusion still leads to a dependency cycle on linux:
nix-shell -p nghttp2 --show-trace
error: while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘shell’ at /etc/nixos/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘nghttp2-1.20.0’ at /etc/nixos/nixpkgs/pkgs/development/libraries/nghttp2/default.nix:19:3:
while evaluating the attribute ‘configureFlags’ of the derivation ‘systemd-232’ at /etc/nixos/nixpkgs/pkgs/os-specific/linux/systemd/default.nix:13:3:
while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘kbd-2.0.3’ at /etc/nixos/nixpkgs/pkgs/os-specific/linux/kbd/default.nix:4:3:
while evaluating the attribute ‘autoconf’ of the derivation ‘hook’ at /etc/nixos/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘autoconf-2.69’ at /etc/nixos/nixpkgs/pkgs/development/tools/misc/autoconf/default.nix:4:3:
while evaluating the attribute ‘src’ of the derivation ‘gnum4-1.4.18’ at /etc/nixos/nixpkgs/pkgs/development/tools/misc/gnum4/default.nix:4:3:
while evaluating the attribute ‘nativeBuildInputs’ of the derivation ‘m4-1.4.18.tar.bz2’ at /etc/nixos/nixpkgs/pkgs/build-support/fetchurl/default.nix:96:3:
while evaluating the attribute ‘propagatedNativeBuildInputs’ of the derivation ‘curl-7.53.1’ at /etc/nixos/nixpkgs/pkgs/tools/networking/curl/default.nix:24:3:
infinite recursion encountered, at undefined position
Corrected c-ares attribute name Full changelog : https://nghttp2.org/blog/2017/02/26/nghttp2-v1-20-0/
|
Removed entirely the Also removed the shebang correction in |
Motivation for this change
Package update. This PR is targeted at staging because a mass-rebuild is expected.
Full changelog : https://nghttp2.org/blog/2017/02/26/nghttp2-v1-20-0/
Corrected c-ares attribute name
Patching shebang in fetch-ocsp-response [REMOVED]
Adding SystemD support for nghttpx [REMOVED]
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)