jemalloc: 4.3.1 -> 4.5.0 #23943
jemalloc: 4.3.1 -> 4.5.0 #23943
Conversation
|
@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kirelagin, @wkennington and @copumpkin to be potential reviewers. |
|
Companion to #23944 for a mass-rebuild |
| }; | ||
|
|
||
| # By default, jemalloc puts a je_ prefix onto all its symbols on OSX, which | ||
| # then stops downstream builds (mariadb in particular) from detecting it. This | ||
| # option should remove the prefix and give us a working jemalloc. | ||
| configureFlags = stdenv.lib.optional stdenv.isDarwin "--with-jemalloc-prefix="; | ||
|
|
||
| preInstall = '' | ||
| substituteInPlace bin/jeprof --replace '#! /usr/bin/env perl' '#!/run/current-system/sw/bin/perl' |
There was a problem hiding this comment.
Same thing: this won’t work on non-NixOS.
There was a problem hiding this comment.
Would it be possible to use Perl from Nixpkgs instead?
There was a problem hiding this comment.
these shebangs are patched automatically if perl is in buildInputs.
There was a problem hiding this comment.
Indeed this should point to Perl in the store and not to the symlink in current-system.
But do we want jemalloc to depend on Perl ? :/
There was a problem hiding this comment.
maybe if we have separate build outputs like ["dev", "bin", "lib"]
|
Removed the unnecessary preInstall action. The perl script |
Motivation for this change
Package update.
This PR is targeted at staging because a mass-rebuild is expected.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)