Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sipp: 3.4-beta2 -> 3.5.1 #23945

Closed
wants to merge 1 commit into from
Closed

sipp: 3.4-beta2 -> 3.5.1 #23945

wants to merge 1 commit into from

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Mar 16, 2017

Motivation for this change

fixes build for 17.03 (#23253)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 closed this in 9bd988e Mar 16, 2017
Mic92 pushed a commit that referenced this pull request Mar 16, 2017
@womfoo @Mic92
sipp: 3.4-beta2 -> 3.5.1
8625211 
fixes #23945
@womfoo womfoo deleted the bump/sippy-3.5.1 branch April 30, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@womfoo