implement IntoIterator for SliceCache #11
Closed
+74
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have the ability to dump the arp cache. One way to do this is to iterate over the cache, which is what this PR implement. If you are ok with this change, I'd like to add an
iter_arp_cache
method onEthernetInterface
.While implementing this, I noticed that the ARP cache could have entries with non unicast ip addresses (like
0.0.0.0
,0.0.0.1
or255.255.255.255
). Is this intentional? Shouldn't the insert fail when trying to insert such entries? If that's intentional, I'll remove 26b78ae and makeSliceCacheIterator
work for these entries. Otherwise, I can work on a fix.I also noticed that the
lru
counter was not incremented on insert. I took the liberty to add this but I can revert if that was intentional.