keras: depend on tensorflow #23595
Closed
keras: depend on tensorflow #23595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it necessary to add tensorflow here? Can't you, as a user, just create a Python env where you have keras and then add tensorflow to the env? |
FRidh
requested changes
Mar 8, 2017
| @@ -7,10 +7,13 @@ | |||
| , pytest_xdist | |||
| , six | |||
| , Theano | |||
| , tensorflow ? null | |||
There was a problem hiding this comment.
in any case, we should have only one tensorflow parameter. When this function is called one can choose which tensorflow to pass.
| , pyyaml | ||
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| let tf = if tensorflowWithCuda != null then tensorflowWithCuda else tensorflow; |
|
You're right, there is no need to have tensorflow as a static dependency. Thanks for pointing out my error! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Keras library has now a tensorflow backend. This patch exposes tensorflow to Keras.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)