Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 51.0.1 -> 52.0, firefox-esr: 45.7esr -> 52.0esr #23599

Merged
merged 1 commit into from Mar 7, 2017
Merged

firefox, firefox-bin: 51.0.1 -> 52.0, firefox-esr: 45.7esr -> 52.0esr #23599

merged 1 commit into from Mar 7, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 7, 2017

Motivation for this change
  • Various security fixes (Security Advisories does not seem to be updated: https://www.mozilla.org/en-US/security/known-vulnerabilities/firefox/#firefox52)
  • Added support for WebAssembly
  • Implemented the Strict Secure Cookies specification
  • Added user warnings for non-secure HTTP pages with logins.
  • Enhanced Sync to allow users to send and open tabs from one device to another.
  • Removed support for Netscape Plugin API (NPAPI) plugins other than Flash.
  • Display (but allow users to override) an “Untrusted Connection” error when encountering SHA-1 certificates that chain up to a root certificate included in Mozilla’s CA Certificate Program.
  • Improved experience for downloads
  • Removed Battery Status API
  • Enabled CSS Grid Layout
  • Improved security for screen sharing
  • Redesigned Responsive Design Mode

https://www.mozilla.org/en-US/firefox/52.0/releasenotes/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @wkennington to be potential reviewers.

@edolstra edolstra merged commit 8e4513f into NixOS:master Mar 7, 2017
@edolstra
Copy link
Member

edolstra commented Mar 7, 2017

Thanks. For easy of cherry-picking, it would be nice to put ESR updates into a separate commit. (For instance, we definitely don't want to update the ESR to a new major version in the stable branch.)

@vcunat
Copy link
Member

vcunat commented Mar 7, 2017 •
edited

Actually, the 45 ESR ends support somewhere in June, so I think we should better pick the bump to 17.03 (now, before release happens). Other opinions? /cc @globin

@rasendubi
Copy link
Member

This patch seem to break firefox: http://hydra.nixos.org/build/49823989

DEBUG: configure:10605: checking for nss-config
DEBUG: configure:10640: checking for NSS - version >= 3.28.3
DEBUG: configure: error: you don't have NSS installed or your version is too old
ERROR: old-configure failed
builder for ‘/nix/store/93cs7h14ga6shabzf7g6kj83zkjxmshm-firefox-unwrapped-52.0.drv’ failed with exit code 1

@rasendubi
Copy link
Member

Seems that our NSS needs an update as well.

checking for nss-config... /nix/store/mjbccpz6whnaj54z8dmzv055r0w97y8b-nss-3.28.1-dev/bin/nss-config
checking for NSS - version >= 3.28.3... no
configure: error: you don't have NSS installed or your version is too old

@rasendubi rasendubi mentioned this pull request Mar 8, 2017
Merged
7 tasks
@rasendubi
Copy link
Member

Opened a PR to update NSS: #23633

@rasendubi
Copy link
Member

sqlite3 also needs an update

checking for sqlite3 >= 3.17.0... Requested 'sqlite3 >= 3.17.0' but version of SQLite is 3.16.2
configure: error: Library requirements (sqlite3 >= 3.17.0) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them.

@rasendubi
Copy link
Member

Opened a PR for sqlite: #23634

@rasendubi
Copy link
Member

As well as icu-18n...

checking for icu-i18n >= 58.1... Requested 'icu-i18n >= 58.1' but version of icu-i18n is 57.1
configure: error: Library requirements (icu-i18n >= 58.1) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them.

@rasendubi
Copy link
Member

Opened a PR for ICU: #23635

@rasendubi
Copy link
Member

After applying all PRs, Firefox finally started to build. Will report later whether it succeeds.

@rasendubi
Copy link
Member

Yep, it did build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taku0 @mention-bot @edolstra @vcunat @rasendubi @bendlas