Git: Make the patchset more granular. #23589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wmertens, @peti and @edolstra to be potential reviewers. |
peti
reviewed
Mar 7, 2017
| @@ -26,12 +26,12 @@ stdenv.mkDerivation { | |||
| hardeningDisable = [ "format" ]; | |||
|
|
|||
| patches = [ | |||
| ./docbook2texi.patch | |||
| ./symlinks-in-bin.patch | |||
| ./git-sh-i18n.patch | |||
| ./ssh-path.patch | |||
There was a problem hiding this comment.
You probably meant to remove this patch here?
| ./symlinks-in-bin.patch | ||
| ./git-sh-i18n.patch | ||
| ./ssh-path.patch | ||
| ./ssl-cert-file.patch | ||
| ]; | ||
| ] ++ stdenv.lib.optionals withManual [ ./docbook2texi.patch ] | ||
| ++ stdenv.lib.optionals guiSupport [ ./ssh-path.patch ]; |
There was a problem hiding this comment.
I think you've renamed that file as part of this change.
|
This doesn't apply anymore. @spacekitteh, are you still interested in getting this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Splitting up the patch set for more granularity.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)