Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxqt: fix qtsvg attribute #23588

Merged
merged 1 commit into from Mar 10, 2017
Merged

lxqt: fix qtsvg attribute #23588

merged 1 commit into from Mar 10, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 7, 2017

Motivation for this change

Fixes #23397.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer.

bennofs
bennofs reviewed Mar 7, 2017
View reviewed changes
pkgs/desktops/lxqt/default.nix
@@ -71,7 +71,7 @@ let
pkgs.lxmenu-data
pkgs.menu-cache
pkgs.openbox # default window manager
qt5.qtsvg # provides QT5 plugins for svg icons
pkgs.qt5.qtsvg # provides QT5 plugins for svg icons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more correct to use qtsvg instead of pkgs.qt5.qtsvg here. Can you verify that works?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work if qtsvg is used instead of pkgs.qt5.qtsvg:

$ nixos-rebuild build-vm -I nixpkgs=/alt/nixpkgs -I nixos-config=/alt/nixos/configuration.lxqt.nix
building Nix...
building the system configuration...
error: undefined variable ‘qtsvg’ at /alt/nixpkgs/pkgs/desktops/lxqt/default.nix:74:7

@ttuegel ttuegel merged commit 985f54f into NixOS:master Mar 10, 2017
@romildo romildo deleted the fix.lxqt branch March 10, 2017 21:10
@matklad
Copy link
Member

matklad commented Mar 31, 2017

Hm, I still get this error on 17.03:

λ sudo nixos-rebuild switch  --upgrade                                              
downloading Nix expressions from ‘https://d3g5gsiof5omrk.cloudfront.net/nixos/17.03/nixos-17.03.849.1849e69/nixexprs.tar.xz’...
downloading ‘https://d3g5gsiof5omrk.cloudfront.net/nixos/17.03/nixos-17.03.849.1849e69/nixexprs.tar.xz’... [0/0 KiB, 0.0 KiB/s [5727/8269 KiB, 5712.0 KiB/s]
unpacking channels...
created 2 symlinks in user environment
building Nix...
building the system configuration...
error: undefined variable ‘qt5’ at /nix/store/fch32x6q39062w24xif0cghwb4xdsa5s-nixos-17.03.849.1849e69/nixos/pkgs/desktops/lxqt/default.nix:74:7
(use ‘--show-trace’ to show detailed location information)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennofs bennofs bennofs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@romildo @mention-bot @matklad @bennofs @tholzschuh @ttuegel