Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert short nix options to long ones #1280

Closed
wants to merge 1 commit into from

Conversation

aschmolck
Copy link
Contributor

e.g. nix-env -e subversion => nix-env --uninstall subversion

The aim is to make the documention less cryptic for newcomers and the long
options are more self-documenting.

The change was made with the following script:

https://github.com/aschmolck/convert-short-nix-opts-to-long-ones

and sanity checked visually.

e.g. nix-env -e subversion => nix-env --uninstall subversion

The aim is to make the documention less cryptic for newcomers and the long
options are more self-documenting.

The change was made with the following script:

<https://github.com/aschmolck/convert-short-nix-opts-to-long-ones>

and sanity checked visually.
@aschmolck
Copy link
Contributor Author

@edolstra ping: is there a chance of merging this? I'm happy to fix the merge conflicts and make other adjustments if required – I also note there has been an apparently independent similar PR (with smaller scope) recently: #1349

@stale
Copy link

stale bot commented Feb 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 13, 2021
@clemens-tolboom
Copy link
Contributor

@aschmolck I manually fixed/transformed from .xml to .md in #1349 ... as this is now marked stale do you want to try fix this again with your script?

@stale stale bot removed the stale label Feb 13, 2021
@aschmolck
Copy link
Contributor Author

Sure, I'm happy to spend a bit of time to fix the markdown version of the docs, if that's the only thing that's in the way of landing this. Can someone with commit access confirm they are interested in merging this change in principle?

@clemens-tolboom
Copy link
Contributor

Can someone with commit access confirm they are interested in merging this change in principle?

Not sure what the chances are for stale issues :-(

@aschmolck
Copy link
Contributor Author

aschmolck commented Feb 14, 2021

@copumpkin since you're currently assigned to this (and 👍 the original PR 3 years ago), can you comment on whether me bringing it up to date is worth it? (edit: I'm happy to do it, but obviously I'd rather not spend the time if there is little chance of it getting merged).

@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Aug 13, 2021
@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Aug 4, 2022

@aschmolck Really sorry that your PR has been hanging around for so long. Are you still interested in merging this? If so, could you please rebase?

@stale stale bot removed the stale label Aug 4, 2022
@fricklerhandwerk fricklerhandwerk self-assigned this Sep 9, 2022
@Ericson2314
Copy link
Member

Ericson2314 commented Feb 19, 2023

@fricklerhandwerk because this is generated from a script, I suggest we merge your PR to split up the man pages first, and then rerun the script. That should be less rebasing and resolving conflicts.

@aschmolck
Copy link
Contributor Author

Sorry, I missed that there was some renewed interest in this PR @Ericson2314 @fricklerhandwerk. I'm happy to bring it up to date by re-running the scripts (and doing some manual fixups where needed), if that's all that's needed to land this?

@fricklerhandwerk
Copy link
Contributor

@aschmolck nice! I agree with @Ericson2314 though that we should merge the large manual PR first.

@thufschmitt thufschmitt added the idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. label Mar 31, 2023
@Ericson2314
Copy link
Member

#7518 is now merged, so let's do this! I guess the easiest thing to do is re-run the script, and then force push?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-03-31-nix-team-meeting-minutes-45/27002/1

@aschmolck
Copy link
Contributor Author

@Ericson2314 Cool, I'll have a look at this later today.

@aschmolck
Copy link
Contributor Author

@Ericson2314 this actually required a bit of work to bring up-to-date and I also I also found a small bug in nix-info along the way and had to create a new PR (since I no longer have access to the original repo), but here we go: #8276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants