Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: reenable ALSA backend #23989

Merged
merged 1 commit into from Mar 20, 2017
Merged

firefox: reenable ALSA backend #23989

merged 1 commit into from Mar 20, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 17, 2017

Motivation for this change

Starting from release 52.0 the ALSA backend is disabled by default so firefox won't play any sound unless PulseAudio is configured and running. Since NixOS uses ALSA by default it should be enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using (icedtea-web-1.6.2 fails but I doubt it's related)
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @taku0 to be potential reviewers.

@edolstra edolstra merged commit 8150455 into NixOS:master Mar 20, 2017
@rnhmjoj rnhmjoj deleted the firefox-alsa branch September 12, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants