Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssh_hpn: build current version #23990

Closed
wants to merge 2 commits into from
Closed

openssh_hpn: build current version #23990

wants to merge 2 commits into from

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Mar 17, 2017 •
edited

Motivation for this change

Needed an HPN build of openssh and the old patches no longer apply.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@fadenb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @peti and @jbgi to be potential reviewers.

@aneeshusa
Copy link
Contributor

cc me as maintainer

@fadenb
Copy link
Contributor Author

fadenb commented Mar 18, 2017

Can someone restart travis? Failed due to "error: preallocating file of 47312544 bytes: No space left on device" as well as run time limitation

@aneeshusa aneeshusa mentioned this pull request Mar 21, 2017
Merged
7 tasks
@aneeshusa
Copy link
Contributor

It looks like there is a SSH-HPN release for the newly released 7.5p1 at https://github.com/rapier1/openssh-portable/releases, although I'm not sure if we should wait a few days for that to settle/any further changes to happen.

@fadenb fadenb force-pushed the openssh_hpn branch 2 times, most recently from 1ea53c8 to 6250534 Compare March 23, 2017 10:14
@aneeshusa @fadenb
openssh: 7.4p1 -> 7.5p1
a83d591 
Release notes are available at https://www.openssh.com/txt/release-7.5.
Mostly a bugfix release, no major backwards-incompatible changes.

Remove deprecated `UsePrivilegeSeparation` option,
which is now mandatory.
@fadenb
Copy link
Contributor Author

fadenb commented Apr 12, 2017

Just rebased on top of the PR by @aneeshusa (#24179)
Seems to be working fine. Anyone else that can test openssh_hpn?

@fadenb fadenb changed the title [WIP] openssh_hpn: build current version openssh_hpn: build current version Apr 12, 2017
@vcunat
Copy link
Member

vcunat commented Apr 14, 2017

Looks OK. I just tried our nixos test with the patched sshd.

@vcunat vcunat closed this in c395568 Apr 14, 2017
@fadenb fadenb deleted the openssh_hpn branch April 21, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fadenb @mention-bot @aneeshusa @vcunat @ndowens