Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: use generic builder and add 0.9.0 #23979

Merged
merged 1 commit into from Mar 17, 2017
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

terraform is project that changes quite quickly and some people may be needing older versions (@shlevy) so this PR introduces a generic builder that allows us to easily have multiple versions.

We also lock terragrunt to v0.8 due to the breaking changes in 0.9.

Supersedes #23977

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm, @brainrape and @siddharthist to be potential reviewers.

@peterhoeg peterhoeg mentioned this pull request Mar 17, 2017
7 tasks
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@zimbatm zimbatm merged commit c216a71 into NixOS:master Mar 17, 2017
@peterhoeg peterhoeg deleted the u/tf branch March 18, 2017 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants