Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmod: 23 -> 24 and update kmod-blacklist-ubuntu to zesty #23983

Merged
merged 2 commits into from Mar 20, 2017
Merged

kmod: 23 -> 24 and update kmod-blacklist-ubuntu to zesty #23983

merged 2 commits into from Mar 20, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change
  • kmod was out of date.
  • kmod-blacklist-ubuntu was very out of date

Further to #23890.

I haven't tried this on stable.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Peter Hoeg added 2 commits March 17, 2017 16:05
@peterhoeg
kmod-blacklist-ubuntu: 9.3 -> 22.1
820b096 
(cherry picked from commit 0c262a6)
@peterhoeg
kmod: 23 -> 24
c4ff112 
(cherry picked from commit 89724f1)
@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @edolstra and @abbradar to be potential reviewers.

@7c6f434c
Copy link
Member

mass-rebuild via systemd

@vcunat
Copy link
Member

vcunat commented Mar 20, 2017

Any reason not to port the i2c change? (from that PR on master)

@vcunat vcunat changed the base branch from release-17.03 to staging-17.03 March 20, 2017 21:33
@vcunat vcunat merged commit c4ff112 into NixOS:staging-17.03 Mar 20, 2017
vcunat added a commit that referenced this pull request Mar 20, 2017
@vcunat
Merge #23983: update kmod and kmod-blacklist-ubuntu
2722b1c
@vcunat
Copy link
Member

vcunat commented Mar 20, 2017

Well, I merged these at least immediately, in case Hydra wanted to evaluate that branch, but I'd still like to understand that missing commit.

@peterhoeg peterhoeg deleted the u/kmod_stable branch March 21, 2017 00:49
@peterhoeg
Copy link
Member Author

I left out that commit because I didn't want to introduce a functionality change in the release branch so close to actual release.

@peterhoeg peterhoeg restored the u/kmod_stable branch March 21, 2017 04:00
@vcunat
Copy link
Member

vcunat commented Mar 21, 2017

Right, let's leave it that way.

@peterhoeg peterhoeg deleted the u/kmod_stable branch March 21, 2017 10:36
@peterhoeg peterhoeg restored the u/kmod_stable branch March 21, 2017 12:10
@peterhoeg peterhoeg deleted the u/kmod_stable branch April 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: mass-rebuild 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @mention-bot @7c6f434c @vcunat @pSub