Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pygame: 1.9.1 -> 1.9.3 #23981

Merged
merged 1 commit into from Mar 17, 2017
Merged

pygame: 1.9.1 -> 1.9.3 #23981

merged 1 commit into from Mar 17, 2017

Conversation

lheckemann
Copy link
Member

Motivation for this change

New upstream release; supports python 3.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip". In progress.
    • Renpy fails to build; will try updating it to the latest upstream release.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lheckemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @aszlig and @abbradar to be potential reviewers.

@7c6f434c 7c6f434c merged commit 7ff2701 into NixOS:master Mar 17, 2017
@lheckemann
Copy link
Member Author

@7c6f434c this breaks renpy, as mentioned in the description; I was hoping to fix that before getting this merged

@7c6f434c
Copy link
Member

Oops, sorry

@lheckemann
Copy link
Member Author

To be fair, renpy built fine before this change but it doesn't actually run... So I think the most appropriate course of action would be to mark it as broken?

@7c6f434c
Copy link
Member

Well, updating it has a chance of being really easy — need to build the dependencies first, though.

@lheckemann
Copy link
Member Author

It's not really easy, it complains about not being able to find SDL2 even though I've added it to the build inputs.

@lheckemann lheckemann deleted the pygame branch March 17, 2017 10:56
@lheckemann lheckemann mentioned this pull request Mar 17, 2017
Merged
6 tasks
@7c6f434c
Copy link
Member

It is not supposed to be built with pygame anyway, they want their own pygames_sdl2 fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lheckemann @mention-bot @7c6f434c @FRidh