Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cipher suite strings for IBM JRE #126

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

ysohda
Copy link
Contributor

@ysohda ysohda commented Mar 13, 2017

Add cipher suite strings for IBM JRE into SuiteToOSSL mapping

@kares
Copy link
Member

kares commented Mar 14, 2017

Thanks Yuki, this is excellent ... if you get a chance could you pls update the comment with a note from #125

/* For IBM JRE */

to something like :

/* For IBM JRE: suite names start with "SSL_". On Oracle JRE, the suite names start with "TLS_" */

Add cipher suite strings for IBM JRE into SuiteToOSSL mapping
Add EDCH/EDCHE SHA384 cipher suites into SuiteToOSSL mapping
@ysohda ysohda force-pushed the add-ibm-jre-cipher-suites branch from 4c7af7c to 4f38a1a Compare March 15, 2017 01:04
@ysohda
Copy link
Contributor Author

ysohda commented Mar 15, 2017

Hi Kares,

Thank you for your review.
I updated the comment and also made EDCH/EDCHE SHA384 cipher suites available not only for IBM JRE but also for Oracle JRE.
Btw, about AES GCM ciper cuites introduced in Java 8, I added mapping entries for IBM JRE. So if AES GCM cipher suites are available on jruby-openssl, they will be also available on IBM JRE.

Thank you,
Yuki.

@ysohda
Copy link
Contributor Author

ysohda commented Mar 21, 2017

Hi @kares ,

Can I have any update?
It would be nice that the fix is included in the next JRuby-Openssl and JRuby releases (0.9.21 & 9.1.9).

Thank you,
Yuki.

@kares
Copy link
Member

kares commented Mar 21, 2017

Sure will be in next jossl release. Not sure if it will make it into 9.1.9 (its a lot of boilerplate to test a release).
But you'll be able to gem update later and we can push you a dev SNAPSHOT if that is usable for you ...

@kares kares merged commit 580ea57 into jruby:master Mar 21, 2017
@ysohda
Copy link
Contributor Author

ysohda commented Mar 31, 2017

Hi Kares,

Thank you for creating a snapshot. I'm going to use it.
May I have an approximate next release date if it is planned?

Thank you,
Yuki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants