support passing time/size params for the scroller #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
approved these changes
Apr 18, 2017
lib/MetaCPAN/Client.pm
Outdated
|
|
||
| Note: please use with caution. | ||
|
|
||
| This parameter will set the max. lifetime of the ElasticSearch scroller |
There was a problem hiding this comment.
"This parameter will set the maximum lifetime of the Elasticsearch scroller"
|
@oalders cool, thanks. |
|
test failure cannot be recreated... probably temp and doesn't seem to have anything to do with the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for using setting of scroller time/size values.
I want to make sure the wording in the doc explains that it's not recommended to use / you have to understand what these params do.