tmate: 2.2.0 -> 2.2.1 #23326
Merged
tmate: 2.2.0 -> 2.2.1 #23326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manveru, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DamienCassou and @sigma to be potential reviewers. |
matthiasbeyer
requested changes
Mar 5, 2017
|
|
||
| src = fetchFromGitHub { | ||
| owner = "nviennot"; | ||
| owner = "tmate-io"; |
There was a problem hiding this comment.
Can we have a comment on why the owner changed?
Possibly in the commit itself?
There was a problem hiding this comment.
Well, if you go to https://github.com/nviennot/tmate you'll be redirected to https://github.com/tmate-io/tmate so I'd say the author created an org and moved the repo there. I'm simply reflecting that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Minor upgrade
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)