lilyterm-git: init at 2017-01-06 #23327
Conversation
|
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres and @wkennington to be potential reviewers. |
The latest stable release is quite old (2013-02) and many improvements have been made in the meantime.
|
The failing build is unrelated. |
|
I need to create a plan for testing it. Tomorrow I will run it! |
| , pkgconfig | ||
| , autoconf, automake, intltool, gettext | ||
| , gtk, vte }: | ||
| , gtk, vte | ||
|
|
There was a problem hiding this comment.
To separate the the “manual” arguments from the “automatic” ones (i.e. included by callPackage by default).
|
Will merge, thanks for the reviews. |
|
|
||
| stdenv.mkDerivation rec { | ||
| # "stable" or "git" | ||
| , flavour ? "stable" |
There was a problem hiding this comment.
About that line normally I would put the option description in the same line, after the parameter itself (except if it was something more elaborate).
It is more natural to read that way: flavour ? "stable" # options: git, stable
There was a problem hiding this comment.
Well, that’s a pretty minor choice of style I’d say.
The latest stable release is quite old (2013-02) and many improvements have been
made in the meantime.
New version builds, old version evaluates to the same store path.