Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locate: fix security.wrappers #23335

Merged
merged 1 commit into from Mar 2, 2017
Merged

locate: fix security.wrappers #23335

merged 1 commit into from Mar 2, 2017

Conversation

gkleen
Copy link
Contributor

@gkleen gkleen commented Mar 1, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pngwjpgh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin, @edolstra and @Fuuzetsu to be potential reviewers.

@LnL7
Copy link
Member

LnL7 commented Mar 1, 2017

/cc @ixmatus

@LnL7 LnL7 added this to the 17.03 milestone Mar 1, 2017
Copy link
Contributor

@ixmatus ixmatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you.

@globin globin merged commit 3deb85b into NixOS:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants