This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Better server unavailable error #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
req.onerror is needed to catch connection denied (as opposed to a non-200 request error)
|
@ianb Hmm, the notification looks a bit odd:
|
|
I suppose we could strip |
|
I'm seeing that busted notification in a few other spots, so I"ll just file a bug about it and finish this review |
jaredhirsch
approved these changes
Mar 20, 2017
There was a problem hiding this comment.
I'm seeing a nicer 'Cannot connect to the page shot server' error, followed about half a second later by a Link Copied notification (with undefined as the string in the clipboard).
This code looks good, and the Link Copied error doesn't seem related. I'll file a followup bug to not show the Link Copied notification if there's no link.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handling wasn't really working here