Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plex: 1.3.3.3148 -> 1.5.5.3634 #24138

Merged
merged 1 commit into from Apr 16, 2017
Merged

plex: 1.3.3.3148 -> 1.5.5.3634 #24138

merged 1 commit into from Apr 16, 2017

Conversation

pjones
Copy link
Contributor

@pjones pjones commented Mar 20, 2017

Motivation for this change

Update Plex to the latest version so that I can use https://app.plex.tv.

Things done
  • Tested in my local NixOS container for Plex w/ my media and Roku
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pjones, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Forkk, @colemickens and @dezgeg to be potential reviewers.

@pjones
Copy link
Contributor Author

pjones commented Apr 7, 2017

New commit: Plex released another version since I submitted this PR so I updated the package again. The previous version was corrupting my SQLite database so this bump also fixes that.

This PR is ready to merge.

@pjones pjones changed the title plex: 1.3.3.3148 -> 1.5.0.3501 plex: 1.3.3.3148 -> 1.5.5.3634 Apr 14, 2017
@pjones
Copy link
Contributor Author

pjones commented Apr 14, 2017

@colemickens or @Forkk Can we get this merged? Thanks.

@colemickens
Copy link
Member

Looks fine to me, but I don't have merge powers.

@joachifm joachifm merged commit 7928dbd into NixOS:master Apr 16, 2017
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants