Sitehelper login #2413
Sitehelper login #2413
Conversation
This improves the logging for synchronous errors by adding the stack, and adds equivalent logging to async promise errors
…t needed for a match
Change auth.login() to return the login success Change auth.login() to have options for asking about ownership information, and suppressing register-on-failed-login Change server to do an ownership check on a shot on successful login Add wantsauth script that is used to eagerly talk to the addon and try to initiate login Change shot/controller to use wantsauth
There was a problem hiding this comment.
@ianb I tried running through your STR in the description, but it seems that the shot I created is public by default, so the shot loads without a 404 step in any browser.
That said, I do see the login step in the network traffic:
I also see a login event in the console:
Code looks good, going to land this now
|
|
||
|
|
||
| function sendCustomEvent(name, detail) { | ||
| if (typeof detail == "object") { |
There was a problem hiding this comment.
I guess this is okay: it's not an accurate check for objecthood, but it's unlikely that null, an array, or some oddball object like Math would ever get passed in here.
There was a problem hiding this comment.
The type coercion here is a little sloppy, but objects in particular (as opposed to strings and numbers and null) trigger permission problems when transferring them between the add-on and content. I forgot about null==object though, that's an annoying case, but at least undefined (as when the argument isn't given) will be left alone.
This has a couple cleanup commits that can be looked at separately from the main commit
Testing this is not terribly easy. You have to start run-addon and create a shot, then save the URL of that shot (not as a bookmark). Then shut the browser, start it up again, and try to visit the shot page. It should briefly appear unauthenticated, and then when the add-on auth fires it will change the page to be authenticated and you should be the owner. In theory if you delete cookies and revisit a page it will also re-authenticate.
This doesn't handle My Shots, I'm making a followup for that.