Try to fix the non-deterministic replay by making the ordering of maps and sets deterministic #1274
+129
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
eggrobin
approved these changes
Mar 20, 2017
| bool operator()(not_null<Vessel const*> left, | ||
| not_null<Vessel const*> right) const; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Could we name the types
std::map<not_null<Part*>, T, PartByPartIdComparator>
std::set<not_null<Vessel*>, VesselByGUIDComparator>
std::set<not_null<Vessel const*>, VesselByGUIDComparator>they're a bit of a mouthful, and it's not like we want to mix with comparatorless maps or sets of the same.
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theory is that the computations (e.g., of barycentres) that are done in map/set order yield different results when the order changes due to vessels/parts landing at different addresses. To confirm this we'll need to build a new journal.