Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 6393d433803f
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 295a824abc7c
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Mar 17, 2017

  1. rmilter service: Fix a couple of bugs 

      * The module uses `stringSplit` but it should be `splitString`

  * `rmilter` doesn't actually support binding to multiple sockets.
    Therefore, bind to the last one specified if `socketActivation` is
    `false`.

I also believe there is a bug in this module related to systemd
`ListenStream`.  If `socketActivation` is true, Postfix gets
connection timeouts trying to connect to one of the `ListenStream`
inet addresses.  I don't know enough about `ListenStream` passing
connections on to `fd:3` to understand what's going on.

These changes are in production (with `socketActivation = false`) via NixOps.
    @pjones @fpletz
    pjones authored and fpletz committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    4defb78 View commit details
    Browse the repository at this point in the history

  2. rmilter service: support only one socket

    @fpletz
    fpletz committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    8ab2d2e View commit details
    Browse the repository at this point in the history

  3. rmilter/rspamd service: tighten unix socket permissions

    @fpletz
    fpletz committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    00239ce View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2017

  1. Merge pull request #21866 from pjones/pjones/rmilter 

    rmilter: Fix a couple of bugs
    @fpletz
    fpletz committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    295a824 View commit details
    Browse the repository at this point in the history