sublime3: 3114 -> 3126 #23913
Merged
sublime3: 3114 -> 3126 #23913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremejevs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @demin-dmitriy, @wmertens and @abbradar to be potential reviewers. |
Mic92
added
1.severity: mass-darwin-rebuild
8.has: package (update)
and removed
1.severity: mass-darwin-rebuild
labels
jagajaga
reviewed
Mar 16, 2017
| @@ -66,6 +66,7 @@ in stdenv.mkDerivation { | |||
| phases = [ "installPhase" ]; | |||
| installPhase = '' | |||
| mkdir -p $out/bin | |||
| ln -s ${sublime}/sublime_text $out/bin/subl | |||
There was a problem hiding this comment.
This is a common alias also found in other upstream packages (Mac OS X).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Latest Sublime Text 3.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I wasn't able to find a policy on backporting, though I've seen that Dropbox is being constantly updated in stable branches. Am I supposed to update older stable branches too, and have I done the backport itself correctly? Is there a better approach than this? I haven't tested yet, just looking for feedback.