inspectrum: 20160403 -> 20170218 #23903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquid-dsp is a dependency for the latest git version of inspectrum, therefore I added it in order to be able to upgrade inspectrum.
Mic92
reviewed
Mar 16, 2017
| src = fetchFromGitHub { | ||
| owner = "jgaeddert"; | ||
| repo = "liquid-dsp"; | ||
| rev = "8c1978fa4f5662b8849fe712be716958f29cec0e"; |
There was a problem hiding this comment.
v1.3.0 fails to compile:
/nix/store/ndqahbwrnabiaszk0s8cblhgwhid5kn0-gcc-5.4.0/lib/gcc/x86_64-unknown-linux-gnu/5.4.0/include/pmmintrin.h:50:1: error: inlining failed in call to always_inline '_mm_addsub_ps': target specific option mismatch
_mm_addsub_ps (__m128 __X, __m128 __Y)
^
src/dotprod/src/dotprod_cccf.mmx.c:255:11: error: called from here
s = _mm_addsub_ps( ci, cq );
^
In file included from src/dotprod/src/dotprod_cccf.mmx.c:49:0:
This seems to be fixed in the version I referenced.
Mic92
reviewed
Mar 16, 2017
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "inspectrum-${version}"; | ||
| version = "20160403"; | ||
| version = "20170218"; |
There was a problem hiding this comment.
How about version 0.2, which was released on 3. February?
There was a problem hiding this comment.
Version 0.2 has some bugs, which are fixed in latest git. So the question is if it's preferred to have the version with the tag or the one containing the bugfix...
|
I would vote bugfix one but it's up to someone that can merge this. Just voting 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And as a dependency:
liquid-dsp: init at 20170307