travis: send emails iff commit caused the build to start failing #23905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting should ensure that email notifications are sent *only* when the commit caused the build to start failing. That is, no more "the build is still failing" spam. As an alternative we could consider disabling email notifications outright and possibly enable IRC notifications instead.
|
@joachifm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthewbauer, @mpscholten and @domenkozar to be potential reviewers. |
|
Let's give it a try. |
|
Is someone actively working on making it useful again? This seems like it'll shut things up, but it still looks really bad to have a red badge and all our commits fail (I just had a friend ask me why we were always merging red builds) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting should ensure that email notifications are sent
only when the commit caused the build to start failing. That
is, no more "the build is still failing" spam.
As an alternative we could consider disabling email
notifications outright and possibly enable IRC notifications
instead.
I believe this fixes #23887