Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: metacpan/metacpan-web
base: 915f8935e4cf
Choose a base ref
...
head repository: metacpan/metacpan-web
compare: fe08a3dcca07
Choose a head ref
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 26, 2017

  1. make remove button on email and website work 

    The removeLabel JS function seems to not be used at all any more. It operates on elements with the .control class, but that also seems not to be used at all. There are some references to that class in root/static/openlayers/OpenLayers.js, but I am not sure if that's related. Both the JS function as well as the corresponding less code in root/less/account.less can possibly be removed.
    @simbabque
    simbabque committed Feb 26, 2017
    Copy the full SHA
    c6578fc View commit details
    Browse the repository at this point in the history

  2. fix horizontal spacing for repeatable fields

    @simbabque
    simbabque committed Feb 26, 2017
    Copy the full SHA
    95ec425 View commit details
    Browse the repository at this point in the history

  3. make sure all buttons never behabve like submit 

    Some browsers apparently think that a button is a submit-like button by default. If there's JS on that button, it gets executed when one presses enter in the form. It seems to pick the first button to occur. This only happens in some browsers, and lead to additional email rows being added whenever enter was pressed in any form field. Also see http://stackoverflow.com/a/13534643/1331451.

This changes the behavior insofar that now whenever enter is pressed, the form is submitted and the profile gets saved.

Fixes #1847
    @simbabque
    simbabque committed Feb 26, 2017
    Copy the full SHA
    7e2baa4 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2017

  1. Merge pull request #1855 from simbabque/gh-1847 

    pressing enter in /account/profile
    @oalders
    oalders committed Feb 27, 2017
    Copy the full SHA
    fe08a3d View commit details
    Browse the repository at this point in the history