break gnutls -> openssl dependency #23245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to save ~3.4 MB of openssl from the default closure.
Unfortunately, it seems easiest to build all twice. Debian testing does this in a very similar way. Tested briefly some individual queries and resperf :-)
|
@vcunat, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joachifm, @fpletz and @wkennington to be potential reviewers. |
|
/cc the other unbound maintainer: @ehmry. |
|
I staged this already to start preparing binaries, but feel free to discuss anyway... |
|
Thanks a lot! 👍 Was just about to press merge myself. 🍻 |
vcunat
added a commit
that referenced
this pull request
Mar 1, 2017
(cherry picked from commit 18bd007)
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
(cherry picked from commit 18bd007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The closure of unbound daemon is increased by
nettle.out, but closure ofunbound.libis decreased byopenssl.out(~10x larger). I think it's a fair tradeoff.libgnutls_dane uses libunbound.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)