Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: fix issue #23794 #23795

Closed
wants to merge 1 commit into from
Closed

haskellPackages: fix issue #23794 #23795

wants to merge 1 commit into from

Conversation

VlachJosef
Copy link

Running nix-env -f "<nixpkgs>" -qaP -A haskellPackages on MacOs result in:

error: attribute ‘llvm-general-darwin’ missing, at /nix/store/.../haskell-modules/configuration-nix.nix:231:10
Motivation for this change

Fix for #23794

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@VlachJosef
Listing of haskell packages don't work on MacOS
c6235d6 
Running nix-env -f "<nixpkgs>" -qaP -A haskellPackages on MacOs result in:

error: attribute ‘llvm-general-darwin’ missing, at /nix/store/.../haskell-modules/configuration-nix.nix:231:10
@mention-bot
Copy link

@VlachJosef, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bennofs and @mdorman to be potential reviewers.

@vcunat
Copy link
Member

vcunat commented Mar 12, 2017

Also /cc @peti. The problem has been noticed before, but I can't see what the intention of the intersection was.

@peti
Copy link
Member

peti commented Mar 12, 2017 •
edited

For what it's worth, I don't see what the intended meaning behind that intersect is either. I'm sure @bennofs had some rationale for adding it, though?

@bennofs
Copy link
Contributor

bennofs commented Mar 12, 2017

@peti the reason for the intersect is that configuration-nix really shouldn't add any packages to the set. Imagine you're using configuration-nix with some other pkg set, that contains only a subset of the packages in nixpkgs. Then configuration-nix will add all packages that have overrides in nixpkgs, but all of those packages evaluate to a failure because super.pkg does not exist.

@bennofs
Copy link
Contributor

bennofs commented Mar 12, 2017

I don't understand why llvm-general-darwin is not just defined as a let binding local to the override for llvm-general?

@vcunat
Copy link
Member

vcunat commented Mar 12, 2017

Right, I hid it in 6944818.

@VlachJosef
Copy link
Author

@vcunat thanks for proper fix.

@peti @bennofs given the meaning of intersect is not so obvious and it is really important, it would be nice to put some explanation about it into configuration-nix for future readers.

@VlachJosef VlachJosef closed this Mar 12, 2017
@bennofs
Copy link
Contributor

bennofs commented Mar 12, 2017

@VlachJosef done in 039c6a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@VlachJosef @mention-bot @vcunat @peti @bennofs @Janik-Haag