Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromaprint: 1.3.1 -> 1.3.2 #23781

Merged
merged 1 commit into from Mar 12, 2017
Merged

chromaprint: 1.3.1 -> 1.3.2 #23781

merged 1 commit into from Mar 12, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 12, 2017

Motivation for this change

Update
1.3.2 is the latest that does not cause compile issues for other packages

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @codyopel and @ehmry to be potential reviewers.

@ehmry ehmry self-assigned this Mar 12, 2017
@ehmry ehmry merged commit a7843b0 into NixOS:master Mar 12, 2017
@ehmry
Copy link
Contributor

ehmry commented Mar 12, 2017

Thanks!

@ndowens ndowens deleted the chromaprint branch March 20, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehmry ehmry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndowens @mention-bot @ehmry