Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala: put docs in correct subdirectory #23797

Merged
merged 1 commit into from Mar 12, 2017
Merged

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 12, 2017

Motivation for this change

Under NixOS, /run/current-system/sw/share/doc was getting the license file, etc. from scala. Have just moved them into a subdirectory.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Under NixOS, /run/current-system/sw/share/doc was getting the license
file, etc.
@mention-bot
Copy link

@rvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tobias-hammerschmidt, @MarcWeber and @volth to be potential reviewers.

@Mic92 Mic92 merged commit 847a5d1 into NixOS:master Mar 12, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants