Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drumstick: 1.0.2 -> 1.1.0 #23800

Merged
merged 1 commit into from Mar 12, 2017
Merged

drumstick: 1.0.2 -> 1.1.0 #23800

merged 1 commit into from Mar 12, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 12, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @solson and @dezgeg to be potential reviewers.

@dezgeg dezgeg merged commit 45cfd39 into NixOS:master Mar 12, 2017
@ndowens ndowens deleted the drumstick branch March 20, 2017 23:03
@jtojnar
Copy link
Contributor

jtojnar commented Oct 7, 2017

@ndowens Could you provide the link to the segfault ticket? I am unable to find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndowens @mention-bot @jtojnar @dezgeg