renderdoc: init at version 0.34pre #23769
Conversation
|
Thanks for putting this together! One question: Is vulkan-loader needed for renderdoc to debug vulkan use? If so, presumably it needs to actually be referenced somehow in the package (added to the rpath after unused paths are deleted?). If not, it should be removed from the package's arguments. |
|
After discussion in #renderdoc it sounds like |
| sha256 = "1zpvjvsj5c441kyjpmd2d2r0ykb190rbq474nkmp1jk72cggnpq0"; | ||
| }; | ||
|
|
||
| buildInputs = [ cmake qtbase git pkgconfig xorg.libpthreadstubs xorg.libXdmcp qtx11extras ]; |
There was a problem hiding this comment.
cmake, pkgconfig would go into nativeBuildInputs. Git should not be specified as a dependency
|
I'm not 100% sure if those patchelf invocations are the right thing to do, but it appears to work. (as in, creating and opening vulkan captures with them succeeds, whereas it fails without them) |
|
That seems like a reasonable solution, though I may be wrong. Would it make sense to remove the LD_LIBRARY_PATH munging and do the same rpath magic for librenderdoc? It's a minor quibble, as either works, but consistency is nice. |
|
Actually, is DT_NEEDED meant to be used with absolute paths? My intuition says you're just supposed to have filenames there and let the rpath sort out the location. |
| src = fetchFromGitHub { | ||
| owner = "baldurk"; | ||
| repo = "renderdoc"; | ||
|
|
There was a problem hiding this comment.
Get rid of the empty space between repo and rev
|
|
||
| meta = with stdenv.lib; { | ||
| description = "A single-frame graphics debugger"; | ||
| homepage = "https://renderdoc.org/"; |
There was a problem hiding this comment.
Can remove the quotes around url
Initialising a few commits after the latest release due to some upstream improvements to the build system.
|
Thanks! |
Initialising a few commits after the latest release due to some upstream
improvements to the build system.
Motivation for this change
It was missing. It's also a great app needed by multiple people, including me.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)