Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp11: 0.2.7 -> 0.4.4 #23802

Merged
merged 2 commits into from Mar 18, 2017
Merged

libp11: 0.2.7 -> 0.4.4 #23802

merged 2 commits into from Mar 18, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 12, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg to be a potential reviewer.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 12, 2017

I dont know why travis is failing. It doesn't show libp11 depends on engine_pcks11 on my side at all

@ndowens
Copy link
Contributor Author

ndowens commented Mar 12, 2017

According to https://github.com/OpenSC/libp11 this provides enginepkcs11 after 0.4.0

meta = {
homepage = http://www.opensc-project.org/libp11/;
meta = with stdenv.lib; {
homepage = https://github.com/OpenSC/libp11;
license = "LGPL";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license ended up not cleaned up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops :)

@7c6f434c 7c6f434c merged commit cc9bdcc into NixOS:master Mar 18, 2017
@ndowens ndowens deleted the libp11 branch March 20, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants