Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfitsio: 3.21 -> 3.41 #23778

Merged
merged 1 commit into from Mar 19, 2017
Merged

cfitsio: 3.21 -> 3.41 #23778

merged 1 commit into from Mar 19, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 12, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @urkud and @bjornfor to be potential reviewers.

@vbgl
Copy link
Contributor

vbgl commented Mar 12, 2017

cfitsio no longer builds on darwin: “ld: symbol(s) not found for architecture i386”. The full error can be read in the travis log.

@ndowens ndowens closed this Mar 12, 2017
@ndowens ndowens reopened this Mar 12, 2017
matthiasbeyer
matthiasbeyer requested changes Mar 17, 2017
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is IMO not appropriate.

Could you split this up into two commits: one for the package update and one for the platform change? Also - please add a short note in the second commit why the platform change is necessary.

@ndowens ndowens closed this Mar 17, 2017
@ndowens ndowens reopened this Mar 17, 2017
@ndowens
Copy link
Contributor Author

ndowens commented Mar 17, 2017

@matthiasbeyer There we go, had to reset to old commit and redo it, which closed PR, but got it fixed now :)

@ndowens
cfitsio: 3.21 -> 3.41
64d9947 
cfitsio: Changed platforms to Linux, due to failing to build on Darwin

cfitsio: Fixed missing semicolon

cfitsio: Removed undefined variable
@ndowens ndowens merged commit d97e9ae into NixOS:master Mar 19, 2017
@ndowens ndowens deleted the cfitsio branch March 20, 2017 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ndowens @mention-bot @vbgl @matthiasbeyer @joachifm