Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pure: 0.64 -> 0.66 #23780

Merged
merged 1 commit into from Mar 13, 2017
Merged

pure: 0.64 -> 0.66 #23780

merged 1 commit into from Mar 13, 2017

Conversation

asppsa
Copy link
Contributor

@asppsa asppsa commented Mar 12, 2017

Motivation for this change

Update Pure to the latest version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I've tested that all purePackages still compile in a nix-shell --pure environment, and that a rudimentary pure script that includes every library doesn't segfault.

@mention-bot
Copy link

@asppsa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @vcunat and @pSub to be potential reviewers.

@7c6f434c 7c6f434c merged commit a77380b into NixOS:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asppsa @mention-bot @joachifm @7c6f434c