Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml-llvm: 3.7.1 -> 3.9.1 #23803

Merged
merged 1 commit into from Mar 13, 2017
Merged

ocaml-llvm: 3.7.1 -> 3.9.1 #23803

merged 1 commit into from Mar 13, 2017

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 12, 2017

Motivation for this change

#23790

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vbgl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @sternenseemann and @FlorentBecker to be potential reviewers.

@vbgl vbgl mentioned this pull request Mar 12, 2017
Closed
@romildo
Copy link
Contributor

romildo commented Mar 13, 2017

I have tested with success for the toy compiler for the Kaleidoscope language provided in the LLVM tutorial.

$ cd /tmp
$ wget http://releases.llvm.org/3.9.1/llvm-3.9.1.src.tar.xz
$ tar -Jxvf /var/tmp/llvm-3.9.1.src.tar.xz 
$ cd llvm-3.9.1.src/examples/OCaml-Kaleidoscope/Chapter3/
$ nix-shell --pure -p gcc llvm "(recurseIntoAttrs (callPackage /alt/nixpkgs/pkgs/top-level/ocaml-packages.nix {}).ocamlPackages_latest)."{ocaml,ocamlbuild,findlib,camlp4,llvm}
$ ocamlbuild toy.byte -use-ocamlfind -package llvm
$ ./toy.byte

@vbgl vbgl merged commit b2b8a41 into NixOS:master Mar 13, 2017
@vbgl
Copy link
Contributor Author

vbgl commented Mar 13, 2017

Thanks for the feedback.

@vbgl vbgl deleted the ocaml-llvm branch September 4, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @mention-bot @romildo @joachifm