haskell-packages: Add minimal benchDepends support #23235
Conversation
|
@expipiplus1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @cstrahan and @basvandijk to be potential reviewers. |
domenkozar
added
6.topic: haskell
9.needs: changelog
expipiplus1
force-pushed
the
haskell-bench
branch
from
fa64408 to
fdd9d7f
Compare
|
Looks harmless :) |
| @@ -13,6 +13,7 @@ | |||
| , configureFlags ? [] | |||
| , description ? "" | |||
| , doCheck ? !isCross && (stdenv.lib.versionOlder "7.4" ghc.version) | |||
| , doBench ? false | |||
There was a problem hiding this comment.
This option suggests to users that the build would run (or compile) the package's benchmarks, but in fact it does not. That feels a little counter-intuitive and misleading.
There was a problem hiding this comment.
would withBenchmarkDepends be better? I'm not sure when we'd want to run the benchmarks in a nix build. My use case here is to make the benchmark dependencies available in the shell environment.
| @@ -38,6 +39,7 @@ | |||
| , passthru ? {} | |||
| , pkgconfigDepends ? [], libraryPkgconfigDepends ? [], executablePkgconfigDepends ? [], testPkgconfigDepends ? [] | |||
| , testDepends ? [], testHaskellDepends ? [], testSystemDepends ? [] | |||
| , benchDepends ? [] | |||
There was a problem hiding this comment.
As mentioned elsewhere, this option should be called "benchmarkDepends", IMHO, for consistency.
There was a problem hiding this comment.
gotcha, I'll open another PR.
See also: NixOS/cabal2nix#262
cc @peti