emem: 0.2.41 -> 0.2.42 #23976
emem: 0.2.41 -> 0.2.42 #23976
Conversation
| @@ -2,14 +2,14 @@ | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| pname = "emem"; | |||
| version = "0.2.41"; | |||
| version = "0.2.42"; | |||
| name = "${pname}-${version}"; | |||
|
|
|||
| inherit jdk; | |||
|
|
|||
| src = fetchurl { | |||
There was a problem hiding this comment.
Use fetchFromGitHub instead of fetchurl
There was a problem hiding this comment.
I need the JAR file for this to work.
There was a problem hiding this comment.
Not talking about jdk; talking about chaning fetchurl to fetchFromGitHub
There was a problem hiding this comment.
Can fetchFromGitHub download a release file?
There was a problem hiding this comment.
yup, easily. you look at the release url, such as https://github.com/ebzzry/emem/archive/v0.2.42.tar.gz at the end it is v0.2.42 ; so your rev would be:
rev = "v${version}";
if it didnt have v before version, rev would be rev = version or rev = "${version}"; whichever
There was a problem hiding this comment.
Okay! However, I don’t need the .tar.gz file. It’s the .jar file, specifically, that I need.
There was a problem hiding this comment.
ah, hmm didn't think about that :) Sorry, well if you didn't know the above method, at least you know now :)
There was a problem hiding this comment.
On the other hand, I’m experimenting with a source build! :)
| name = "${pname}-${version}"; | ||
|
|
||
| inherit jdk; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/ebzzry/${pname}/releases/download/v${version}/${pname}.jar"; | ||
| sha256 = "0pg7m4fyrcbm8d5nj96xvvh1cvml501rw34hniqq384waifr2kqs"; | ||
| sha256 = "0zm3sqgbiaj44nkgkjiifxwwyrcjs42nry6zmbg3dnnpd0v82v8j"; | ||
| }; | ||
|
|
||
| buildInputs = [ ]; |
There was a problem hiding this comment.
If there is no buildinputs I'd remove the line
|
Should this go in? |
|
Yes, for now! :) |
|
Thanks! |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)