umockdev: init at 0.8.13 #23967
Merged
umockdev: init at 0.8.13 #23967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umockdev: all-packages cosmetic change
7c6f434c
requested changes
Mar 18, 2017
|
|
||
| preConfigure = '' | ||
| # sed -i 's|gobject-2.0 >= 2.32.0 gio-2.0 >= 2.32.0 gio-unix-2.0 >= 2.32.0)|gobject-2.0 >= 2.32.0, gio-2.0 >= 2.32.0, gio-unix-2.0 >= 2.32.0)|g' configure | ||
| ''; |
There was a problem hiding this comment.
This can be removed because the only line is commented out, right?
|
Forgot to remove. I comment out to test at times 😀
…Sent from my iphone
On Mar 18, 2017, 2:02 PM -0500, Michael Raskin ***@***.***>, wrote:
@7c6f434c requested changes on this pull request.
In pkgs/development/libraries/umockdev/default.nix (#23967 (comment)):
> + rev = version; + sha256 ="0bw2dpshlgbdwg5mhq4j22z474llpqix8pxii63r2bk5nhjc537k"; + }; + + buildInputs = [ glib systemd libgudev vala ]; + nativeBuildInputs = [ autoreconfHook pkgconfig ]; + + ### docs/gtk-doc.make not found + prePatch = '' + sed -i 's|include $(top_srcdir)/docs/gtk-doc.make||g' docs/reference/Makefile.am + sed -i 's|+=|=|g' docs/reference/Makefile.am + ''; + + preConfigure = '' + # sed -i 's|gobject-2.0 >= 2.32.0 gio-2.0 >= 2.32.0 gio-unix-2.0 >= 2.32.0)|gobject-2.0 >= 2.32.0, gio-2.0 >= 2.32.0, gio-unix-2.0 >= 2.32.0)|g' configure + '';
This can be removed because the only line is commented out, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#23967 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7y0LmCLsGGVKSoViFreDhfK25dgLks5rnCpigaJpZM4Mf_Ok).
|
|
That's why you are supposed to comment out the entire Nix variable definition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New package for a required package that I am updating
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)