Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper: 0.8.3 -> 1.3.1 #23969

Merged
merged 1 commit into from Mar 18, 2017
Merged

hyper: 0.8.3 -> 1.3.1 #23969

merged 1 commit into from Mar 18, 2017

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jlesquembre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @puffnfresh, @hharnisc and @aske to be potential reviewers.

@copumpkin
Copy link
Member

@puffnfresh @jlesquembre any idea whether this is a PITA to build from source or whether you just didn't get around to it? It seems pretty appealing to have on Darwin too (as well as our general preference for source builds)

@jlesquembre
Copy link
Member Author

I tried to make a source build, but without success. I looked to nix-tour as an example of an electron application, and also found the yarn2nix, which maybe helps with the build. Unfortunately I wasn't able to do a successful build, and chose the easy way of using the package for the update. If I have some time, I'll try again, but any guidance on how to build an electron app is appreciated.

@7c6f434c 7c6f434c merged commit 242abd8 into NixOS:master Mar 18, 2017
@jlesquembre jlesquembre deleted the hyper_1.3.1 branch June 6, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants