ppsspp: 1.1.0 → 1.3 #23970
ppsspp: 1.1.0 → 1.3 #23970
Conversation
|
@therealpxc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres, @abbradar and @Fuuzetsu to be potential reviewers. |
| @@ -14,9 +14,9 @@ stdenv.mkDerivation rec{ | |||
|
|
|||
| src = fetchgit { | |||
There was a problem hiding this comment.
fetchFromGitHub is preferred over fetchgit
There was a problem hiding this comment.
I think PPSSPP needs to use fetchgit because the repo uses submodules and fetchFromGitHub currently lacks submodule support.
| @@ -14,9 +14,9 @@ stdenv.mkDerivation rec{ | |||
|
|
|||
| src = fetchgit { | |||
| url = "https://github.com/hrydgard/ppsspp.git"; | |||
| rev = "8c8e5de89d52b8bcb968227d96cbf049d04d1241"; | |||
| rev = "6d0d36bf914a3f5373627a362d65facdcfbbfe5f"; | |||
There was a problem hiding this comment.
You can do rev = "v${version}"; here
There was a problem hiding this comment.
Looks like I have to explicitly put "refs/tags/v$version". Is that expected? Has that changed recently?
| fetchSubmodules = true; | ||
| sha256 = "1q21qskzni0nvz2yi2m17gjh4i9nrs2l4fm4y2dww9m29xpvzw3x"; | ||
| sha256 = "0l8vgdlw657r8gv7rz8iqa6zd9zrbzw10pwhcnahzil7w9qrd03g"; | ||
| }; | ||
|
|
||
| buildInputs = [ zlib libpng pkgconfig qt4 qmake4Hook ] |
There was a problem hiding this comment.
pkgconfig qmake4Hook belongs in nativeBuildInputs
ndowens
force-pushed
the
ppsspp
branch
2 times, most recently
from
442c5e6
to
feefbf7
Compare
|
Sorry, something happened with pushing changes to this; I was told it may have been because used pull instead of fetch. Reopen if you still want to submit it I couldn't get it to build correctly either, at first it was missing ffmpeg for dep and then it gave a can't find a file that the program should have provided it seems |
|
I think both of those build issues may be caused by the switch to fetchFromGitHub, if you did that in your version, because it would then have failed to include the required submodules. I've been running this version on NixOS 16.09 for some time, so I know it works there. I've made the recommended changes and I'm rebuilding on my system now to verify that it builds on this branch as well and not just the stable channel. I'll force push and resubmit for your review once I can verify that the build works. No worries on clobbering it; thankfully Git is good. Thanks for your time and oversight. :-) |
|
Yeah it might have been the switch. Don't know why. Sorry again about the other PR |
Motivation for this change
new upstream release
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)