Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg21: 2.1.18 -> 2.1.19 #23386

Merged
merged 2 commits into from Mar 6, 2017
Merged

gnupg21: 2.1.18 -> 2.1.19 #23386

merged 2 commits into from Mar 6, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Mar 2, 2017

Motivation for this change

This PR is against staging branch since the libgpg-error update causes a mass rebuild.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @kirelagin and @vrthra to be potential reviewers.

@kirelagin
Copy link
Member

Works fine for me and the YubiKey issue on macOS is fixed in this version indeed.

Copy link
Member

@vrthra vrthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to build on OSX and NixOS

@grahamc grahamc merged commit 33b738b into NixOS:staging Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants