Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nitpick: Init at 1.1 #23389

Merged
merged 4 commits into from Mar 6, 2017
Merged

nitpick: Init at 1.1 #23389

merged 4 commits into from Mar 6, 2017

Conversation

gkleen
Copy link
Contributor

@gkleen gkleen commented Mar 2, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

joachifm commented Mar 5, 2017

Is there a reason why it can't use buildPythonPackage?

@gkleen
Copy link
Contributor Author

gkleen commented Mar 5, 2017

I did some investigation into that; it seems to me buildPythonPackage requires a package specification of some kind and supports a few (looks kinda like haskell's .cabal files to me).
Nitpick doesn't seem to have any in it's repo

@gkleen
Copy link
Contributor Author

gkleen commented Mar 5, 2017

Huh, I just noticed the other format; using buildPythonPackage, now

@joachifm joachifm merged commit 4da7f83 into NixOS:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gkleen @joachifm